Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Improvements based on SonarCloud analysis #386

Merged
merged 33 commits into from
Dec 6, 2023
Merged

Conversation

groldan
Copy link
Member

@groldan groldan commented Dec 6, 2023

JUnit5 test classes and methods should have default package visibility

JUnit5 test classes and methods should have default package visibility
@groldan groldan added the QA label Dec 6, 2023
Field dependency injection should be avoided
Generic wildcard types should not be used in return types
…am.toList()'

"Stream.toList()" method should be used instead of "collectors"
when unmodifiable list needed
@groldan groldan merged commit 286821b into geoserver:main Dec 6, 2023
2 checks passed
@groldan groldan deleted the qa branch December 6, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant